Skip to content

Commit a9c7107

Browse files
dschogitster
authored andcommitted
t3427: fix erroneous assumption
Apart from the `setup` test case, `t3427-rebase-subtree.sh` is made up exclusively of demonstrations of breakages. The tricky thing about such demonstrations is that they are often buggy themselves. In this instance, somewhere over the course of the six iterations of the patch that eventually made it into Git's `master` as 5f35900 (contrib/subtree: Add a test for subtree rebase that loses commits, 2016-06-28), the commit message "files_subtree/master4" was changed to just "master4", but the test cases still expected the old commit message. Let's fix this, at long last. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent b8c6f24 commit a9c7107

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

t/t3427-rebase-subtree.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ test_expect_failure REBASE_P 'Rebase -Xsubtree --preserve-merges --onto commit'
6868
reset_rebase &&
6969
git checkout -b rebase-preserve-merges to-rebase &&
7070
git rebase -Xsubtree=files_subtree --preserve-merges --onto files-master master &&
71-
verbose test "$(commit_message HEAD~)" = "files_subtree/master4" &&
71+
verbose test "$(commit_message HEAD~)" = "master4" &&
7272
verbose test "$(commit_message HEAD)" = "files_subtree/master5"
7373
'
7474

@@ -77,7 +77,7 @@ test_expect_failure REBASE_P 'Rebase -Xsubtree --keep-empty --preserve-merges --
7777
reset_rebase &&
7878
git checkout -b rebase-keep-empty to-rebase &&
7979
git rebase -Xsubtree=files_subtree --keep-empty --preserve-merges --onto files-master master &&
80-
verbose test "$(commit_message HEAD~2)" = "files_subtree/master4" &&
80+
verbose test "$(commit_message HEAD~2)" = "master4" &&
8181
verbose test "$(commit_message HEAD~)" = "files_subtree/master5" &&
8282
verbose test "$(commit_message HEAD)" = "Empty commit"
8383
'
@@ -87,7 +87,7 @@ test_expect_failure 'Rebase -Xsubtree --onto commit' '
8787
reset_rebase &&
8888
git checkout -b rebase-onto to-rebase &&
8989
git rebase -Xsubtree=files_subtree --onto files-master master &&
90-
verbose test "$(commit_message HEAD~2)" = "files_subtree/master4" &&
90+
verbose test "$(commit_message HEAD~2)" = "master4" &&
9191
verbose test "$(commit_message HEAD~)" = "files_subtree/master5" &&
9292
verbose test "$(commit_message HEAD)" = "Empty commit"
9393
'

0 commit comments

Comments
 (0)