help: release strbuf on error return in exec_man_konqueror()

rscharfe · gitster · commit a981a9f0e7fb · 2017-09-07T08:49:27.000+09:00
Signed-off-by: Rene Scharfe &lt;l.s.r@web.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/help.c b/builtin/help.c
@@ -152,6 +152,7 @@ static void exec_man_konqueror(const char *path, const char *page)
 		strbuf_addf(&man_page, "man:%s(1)", page);
 		execlp(path, filename, "newTab", man_page.buf, (char *)NULL);
 		warning_errno(_("failed to exec '%s'"), path);
+		strbuf_release(&man_page);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -152,6 +152,7 @@ static void exec_man_konqueror(const char path, const char page)`
`152`	`152`	`strbuf_addf(&man_page, "man:%s(1)", page);`
`153`	`153`	`execlp(path, filename, "newTab", man_page.buf, (char *)NULL);`
`154`	`154`	`warning_errno(_("failed to exec '%s'"), path);`
	`155`	`+ strbuf_release(&man_page);`
`155`	`156`	`}`
`156`	`157`	`}`
`157`	`158`