test-lib: add test_config_global variant

peff · gitster · commit a96250c6fb61 · 2011-12-11T23:16:24.000-08:00
The point of test_config is to simultaneously set a config
variable and register its cleanup handler, like:

  test_config core.foo bar

However, it stupidly assumes that $1 contained the name of
the variable, which means it won't work for:

  test_config --global core.foo bar

We could try to parse the command-line ourselves and figure
out which parts need to be fed to test_unconfig. But since
this is likely the most common variant, it's much simpler
and less error-prone to simply add a new function.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/test-lib.sh b/t/test-lib.sh
@@ -379,6 +379,11 @@ test_config () {
 	git config "$@"
 }
 
+test_config_global () {
+	test_when_finished "test_unconfig --global '$1'" &&
+	git config --global "$@"
+}
+
 # Use test_set_prereq to tell that a particular prerequisite is available.
 # The prerequisite can later be checked for in two ways:
 #

Original file line number	Diff line number	Diff line change
`@@ -379,6 +379,11 @@ test_config () {`
`379`	`379`	`git config "$@"`
`380`	`380`	`}`
`381`	`381`
	`382`	`+test_config_global () {`
	`383`	`+ test_when_finished "test_unconfig --global '$1'" &&`
	`384`	`+ git config --global "$@"`
	`385`	`+}`
	`386`	`+`
`382`	`387`	`# Use test_set_prereq to tell that a particular prerequisite is available.`
`383`	`388`	`# The prerequisite can later be checked for in two ways:`
`384`	`389`	`#`