Remove "pathlen" from "struct name_entry"

torvalds · Junio C Hamano · commit a8c40471ab08 · 2007-03-21T10:21:56.000-07:00
Since we have the "tree_entry_len()" helper function these days, and
don't need to do a full strlen(), there's no point in saving the path
length - it's just redundant information.

Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/builtin-grep.c b/builtin-grep.c
@@ -378,7 +378,7 @@ static int grep_tree(struct grep_opt *opt, const char **paths,
 			 * decide if we want to descend into "abc"
 			 * directory.
 			 */
-			strcpy(path_buf + len + entry.pathlen, "/");
+			strcpy(path_buf + len + tree_entry_len(entry.path, entry.sha1), "/");
 
 		if (!pathspec_matches(paths, down))
 			;
diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
@@ -854,7 +854,7 @@ static void add_pbase_object(struct tree_desc *tree,
 		unsigned long size;
 		enum object_type type;
 
-		if (entry.pathlen != cmplen ||
+		if (tree_entry_len(entry.path, entry.sha1) != cmplen ||
 		    memcmp(entry.path, name, cmplen) ||
 		    !has_sha1_file(entry.sha1) ||
 		    (type = sha1_object_info(entry.sha1, &size)) < 0)
diff --git a/merge-tree.c b/merge-tree.c
@@ -188,7 +188,7 @@ static void resolve(const char *base, struct name_entry *branch1, struct name_en
 
 static int unresolved_directory(const char *base, struct name_entry n[3])
 {
-	int baselen;
+	int baselen, pathlen;
 	char *newbase;
 	struct name_entry *p;
 	struct tree_desc t[3];
@@ -205,10 +205,11 @@ static int unresolved_directory(const char *base, struct name_entry n[3])
 	if (!S_ISDIR(p->mode))
 		return 0;
 	baselen = strlen(base);
-	newbase = xmalloc(baselen + p->pathlen + 2);
+	pathlen = tree_entry_len(p->path, p->sha1);
+	newbase = xmalloc(baselen + pathlen + 2);
 	memcpy(newbase, base, baselen);
-	memcpy(newbase + baselen, p->path, p->pathlen);
-	memcpy(newbase + baselen + p->pathlen, "/", 2);
+	memcpy(newbase + baselen, p->path, pathlen);
+	memcpy(newbase + baselen + pathlen, "/", 2);
 
 	buf0 = fill_tree_descriptor(t+0, n[0].sha1);
 	buf1 = fill_tree_descriptor(t+1, n[1].sha1);
diff --git a/tree-walk.c b/tree-walk.c
@@ -20,8 +20,8 @@ void *fill_tree_descriptor(struct tree_desc *desc, const unsigned char *sha1)
 static int entry_compare(struct name_entry *a, struct name_entry *b)
 {
 	return base_name_compare(
-			a->path, a->pathlen, a->mode,
-			b->path, b->pathlen, b->mode);
+			a->path, tree_entry_len(a->path, a->sha1), a->mode,
+			b->path, tree_entry_len(b->path, b->sha1), b->mode);
 }
 
 static void entry_clear(struct name_entry *a)
@@ -32,7 +32,6 @@ static void entry_clear(struct name_entry *a)
 static void entry_extract(struct tree_desc *t, struct name_entry *a)
 {
 	a->sha1 = tree_entry_extract(t, &a->path, &a->mode);
-	a->pathlen = tree_entry_len(a->path, a->sha1);
 }
 
 void update_tree_entry(struct tree_desc *desc)
@@ -93,7 +92,6 @@ int tree_entry(struct tree_desc *desc, struct name_entry *entry)
 
 	entry->path = path;
 	len = strlen(path);
-	entry->pathlen = len;
 
 	path += len + 1;
 	entry->sha1 = (const unsigned char *) path;
diff --git a/tree-walk.h b/tree-walk.h
@@ -10,7 +10,6 @@ struct name_entry {
 	const unsigned char *sha1;
 	const char *path;
 	unsigned int mode;
-	int pathlen;
 };
 
 static inline int tree_entry_len(const char *name, const unsigned char *sha1)
diff --git a/tree.c b/tree.c
@@ -101,14 +101,15 @@ int read_tree_recursive(struct tree *tree,
 		if (S_ISDIR(entry.mode)) {
 			int retval;
 			char *newbase;
+			unsigned int pathlen = tree_entry_len(entry.path, entry.sha1);
 
-			newbase = xmalloc(baselen + 1 + entry.pathlen);
+			newbase = xmalloc(baselen + 1 + pathlen);
 			memcpy(newbase, base, baselen);
-			memcpy(newbase + baselen, entry.path, entry.pathlen);
-			newbase[baselen + entry.pathlen] = '/';
+			memcpy(newbase + baselen, entry.path, pathlen);
+			newbase[baselen + pathlen] = '/';
 			retval = read_tree_recursive(lookup_tree(entry.sha1),
 						     newbase,
-						     baselen + entry.pathlen + 1,
+						     baselen + pathlen + 1,
 						     stage, match, fn);
 			free(newbase);
 			if (retval)

Original file line number	Diff line number	Diff line change
`@@ -378,7 +378,7 @@ static int grep_tree(struct grep_opt opt, const char *paths,`
`378`	`378`	`* decide if we want to descend into "abc"`
`379`	`379`	`* directory.`
`380`	`380`	`*/`
`381`		`- strcpy(path_buf + len + entry.pathlen, "/");`
	`381`	`+ strcpy(path_buf + len + tree_entry_len(entry.path, entry.sha1), "/");`
`382`	`382`
`383`	`383`	`if (!pathspec_matches(paths, down))`
`384`	`384`	`;`
Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,8 @@ void fill_tree_descriptor(struct tree_desc desc, const unsigned char *sha1)`
`20`	`20`	`static int entry_compare(struct name_entry a, struct name_entry b)`
`21`	`21`	`{`
`22`	`22`	`return base_name_compare(`
`23`		`- a->path, a->pathlen, a->mode,`
`24`		`- b->path, b->pathlen, b->mode);`
	`23`	`+ a->path, tree_entry_len(a->path, a->sha1), a->mode,`
	`24`	`+ b->path, tree_entry_len(b->path, b->sha1), b->mode);`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`static void entry_clear(struct name_entry *a)`
`@@ -32,7 +32,6 @@ static void entry_clear(struct name_entry *a)`
`32`	`32`	`static void entry_extract(struct tree_desc t, struct name_entry a)`
`33`	`33`	`{`
`34`	`34`	`a->sha1 = tree_entry_extract(t, &a->path, &a->mode);`
`35`		`- a->pathlen = tree_entry_len(a->path, a->sha1);`
`36`	`35`	`}`
`37`	`36`
`38`	`37`	`void update_tree_entry(struct tree_desc *desc)`
`@@ -93,7 +92,6 @@ int tree_entry(struct tree_desc desc, struct name_entry entry)`
`93`	`92`
`94`	`93`	`entry->path = path;`
`95`	`94`	`len = strlen(path);`
`96`		`- entry->pathlen = len;`
`97`	`95`
`98`	`96`	`path += len + 1;`
`99`	`97`	`entry->sha1 = (const unsigned char *) path;`