Mark http-fetch without -a as deprecated

Ben Walton · gitster · commit a6c786fce8da · 2011-08-23T21:36:20.000-07:00
As the use of http-fetch without -a can create an object store that is
invalid to the point where it cannot even be fsck'd, mark it as
deprecated.  A future release should change the default and then
remove the option entirely.

Signed-off-by: Ben Walton &lt;bwalton@artsci.utoronto.ca&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/Documentation/git-http-fetch.txt b/Documentation/git-http-fetch.txt
@@ -15,6 +15,9 @@ DESCRIPTION
 -----------
 Downloads a remote git repository via HTTP.
 
+*NOTE*: use of this command without -a is deprecated.  The -a
+behaviour will become the default in a future release.
+
 OPTIONS
 -------
 commit-id::
diff --git a/http-fetch.c b/http-fetch.c
@@ -56,6 +56,10 @@ int main(int argc, const char **argv)
 		commits = 1;
 	}
 
+	if (get_all == 0)
+		warning("http-fetch: use without -a is deprecated.\n"
+			"In a future release, -a will become the default.");
+
 	if (argv[arg])
 		str_end_url_with_slash(argv[arg], &url);
 

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,10 @@ int main(int argc, const char **argv)`
`56`	`56`	`commits = 1;`
`57`	`57`	`}`
`58`	`58`
	`59`	`+ if (get_all == 0)`
	`60`	`+ warning("http-fetch: use without -a is deprecated.\n"`
	`61`	`+ "In a future release, -a will become the default.");`
	`62`	`+`
`59`	`63`	`if (argv[arg])`
`60`	`64`	`str_end_url_with_slash(argv[arg], &url);`
`61`	`65`