blame: make sure that the last line ends in an LF

dscho · gitster · commit a5ca8367c223 · 2009-10-21T17:16:58.000-07:00
This is convenient when parsing multiple the blame of multiple files,
for example:

    git ls-files -z --exclude-standard -- "*.[ch]" |
    xargs --null -n 1 git blame -p &gt; output

and then analyzing the 'output' file using a seperate script.

Currently the parsing is difficult when not all files have a newline
at EOF, this patch ensures that even such files have a newline at the
end of the blame output.

Signed-off-by: Sverre Rabbelier &lt;srabbelier@gmail.com&gt;
CC: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin-blame.c b/builtin-blame.c
@@ -1604,6 +1604,9 @@ static void emit_porcelain(struct scoreboard *sb, struct blame_entry *ent)
 		} while (ch != '\n' &&
 			 cp < sb->final_buf + sb->final_buf_size);
 	}
+
+	if (sb->final_buf_size && cp[-1] != '\n')
+		putchar('\n');
 }
 
 static void emit_other(struct scoreboard *sb, struct blame_entry *ent, int opt)
@@ -1667,6 +1670,9 @@ static void emit_other(struct scoreboard *sb, struct blame_entry *ent, int opt)
 		} while (ch != '\n' &&
 			 cp < sb->final_buf + sb->final_buf_size);
 	}
+
+	if (sb->final_buf_size && cp[-1] != '\n')
+		putchar('\n');
 }
 
 static void output(struct scoreboard *sb, int option)

Original file line number	Diff line number	Diff line change
`@@ -1604,6 +1604,9 @@ static void emit_porcelain(struct scoreboard sb, struct blame_entry ent)`
`1604`	`1604`	`} while (ch != '\n' &&`
`1605`	`1605`	`cp < sb->final_buf + sb->final_buf_size);`
`1606`	`1606`	`}`
	`1607`	`+`
	`1608`	`+ if (sb->final_buf_size && cp[-1] != '\n')`
	`1609`	`+ putchar('\n');`
`1607`	`1610`	`}`
`1608`	`1611`
`1609`	`1612`	`static void emit_other(struct scoreboard sb, struct blame_entry ent, int opt)`
`@@ -1667,6 +1670,9 @@ static void emit_other(struct scoreboard sb, struct blame_entry ent, int opt)`
`1667`	`1670`	`} while (ch != '\n' &&`
`1668`	`1671`	`cp < sb->final_buf + sb->final_buf_size);`
`1669`	`1672`	`}`
	`1673`	`+`
	`1674`	`+ if (sb->final_buf_size && cp[-1] != '\n')`
	`1675`	`+ putchar('\n');`
`1670`	`1676`	`}`
`1671`	`1677`
`1672`	`1678`	`static void output(struct scoreboard *sb, int option)`