ref_update_reject_duplicates(): use size_t rather than int

mhagger · gitster · commit a552e50e5a82 · 2017-05-23T14:29:55.000+09:00
Eliminate a theoretical risk of integer overflow if the two types have
different sizes.

Signed-off-by: Michael Haggerty &lt;mhagger@alum.mit.edu&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/refs.c b/refs.c
@@ -1705,7 +1705,7 @@ int create_symref(const char *ref_target, const char *refs_heads_master,
 int ref_update_reject_duplicates(struct string_list *refnames,
 				 struct strbuf *err)
 {
-	int i, n = refnames->nr;
+	size_t i, n = refnames->nr;
 
 	assert(err);
 

Original file line number	Diff line number	Diff line change
`@@ -1705,7 +1705,7 @@ int create_symref(const char ref_target, const char refs_heads_master,`
`1705`	`1705`	`int ref_update_reject_duplicates(struct string_list *refnames,`
`1706`	`1706`	`struct strbuf *err)`
`1707`	`1707`	`{`
`1708`		`- int i, n = refnames->nr;`
	`1708`	`+ size_t i, n = refnames->nr;`
`1709`	`1709`
`1710`	`1710`	`assert(err);`
`1711`	`1711`