git-svn: allow "0" in SVN path components

Eric Wong · gitster · commit a0f5a0c82853 · 2016-12-12T10:49:50.000-08:00
Blindly checking a path component for falsiness is unwise, as
"0" is false to Perl, but a valid pathname component for SVN
(or any filesystem).

Found via random code reading.

Signed-off-by: Eric Wong &lt;e@80x24.org&gt;
diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm
@@ -606,7 +606,7 @@ sub minimize_url {
 			my $latest = $ra->get_latest_revnum;
 			$ra->get_log("", $latest, 0, 1, 0, 1, sub {});
 		};
-	} while ($@ && ($c = shift @components));
+	} while ($@ && defined($c = shift @components));
 
 	return canonicalize_url($url);
 }

Original file line number	Diff line number	Diff line change
`@@ -606,7 +606,7 @@ sub minimize_url {`
`606`	`606`	`my $latest = $ra->get_latest_revnum;`
`607`	`607`	`$ra->get_log("", $latest, 0, 1, 0, 1, sub {});`
`608`	`608`	`};`
`609`		`- } while ($@ && ($c = shift @components));`
	`609`	`+ } while ($@ && defined($c = shift @components));`
`610`	`610`
`611`	`611`	`return canonicalize_url($url);`
`612`	`612`	`}`