checkdiff_consume: strtol parameter fix.

Junio C Hamano · Junio C Hamano · commit 9e848163eda6 · 2006-05-21T03:01:59.000-07:00
The second parameter is not the end of string input; it is
the optional return value to retrieve where the parser stopped.

Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/diff.c b/diff.c
@@ -431,7 +431,7 @@ static void checkdiff_consume(void *priv, char *line, unsigned long len)
 	else if (line[0] == '@') {
 		char *plus = strchr(line, '+');
 		if (plus)
-			data->lineno = strtol(plus, line + len, 10);
+			data->lineno = strtol(plus, NULL, 10);
 		else
 			die("invalid diff");
 	}

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ static void checkdiff_consume(void priv, char line, unsigned long len)`
`431`	`431`	`else if (line[0] == '@') {`
`432`	`432`	`char *plus = strchr(line, '+');`
`433`	`433`	`if (plus)`
`434`		`- data->lineno = strtol(plus, line + len, 10);`
	`434`	`+ data->lineno = strtol(plus, NULL, 10);`
`435`	`435`	`else`
`436`	`436`	`die("invalid diff");`
`437`	`437`	`}`