git-prompt.sh: make $f local to __git_eread()

jguenther · gitster · commit 9dd70e0a0d17 · 2014-12-12T15:13:37.000-08:00
This function uses (non-local) $f to store the value of its first parameter.
This can interfere with the user's environment.

Signed-off-by: Justin Guenther &lt;jguenther@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh
@@ -261,7 +261,7 @@ __git_ps1_colorize_gitstring ()
 
 eread ()
 {
-	f="$1"
+	local f="$1"
 	shift
 	test -r "$f" && read "$@" <"$f"
 }

Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,7 @@ __git_ps1_colorize_gitstring ()`
`261`	`261`
`262`	`262`	`eread ()`
`263`	`263`	`{`
`264`		`- f="$1"`
	`264`	`+ local f="$1"`
`265`	`265`	`shift`
`266`	`266`	`test -r "$f" && read "$@" <"$f"`
`267`	`267`	`}`