pretty: drop unused strbuf from parse_padding_placeholder()

peff · gitster · commit 9a1180fc304a · 2019-03-20T18:34:09.000+09:00
Unlike other parts of the --pretty user-format expansion,
this function is not actually writing to the output, but
instead just storing the padding values into a context
struct. We don't need to be passed a strbuf at all.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/pretty.c b/pretty.c
@@ -988,8 +988,7 @@ static size_t parse_color(struct strbuf *sb, /* in UTF-8 */
 	return rest - placeholder;
 }
 
-static size_t parse_padding_placeholder(struct strbuf *sb,
-					const char *placeholder,
+static size_t parse_padding_placeholder(const char *placeholder,
 					struct format_commit_context *c)
 {
 	const char *ch = placeholder;
@@ -1194,7 +1193,7 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */
 
 	case '<':
 	case '>':
-		return parse_padding_placeholder(sb, placeholder, c);
+		return parse_padding_placeholder(placeholder, c);
 	}
 
 	/* these depend on the commit */

Original file line number	Diff line number	Diff line change
`@@ -988,8 +988,7 @@ static size_t parse_color(struct strbuf sb, / in UTF-8 */`
`988`	`988`	`return rest - placeholder;`
`989`	`989`	`}`
`990`	`990`
`991`		`-static size_t parse_padding_placeholder(struct strbuf *sb,`
`992`		`- const char *placeholder,`
	`991`	`+static size_t parse_padding_placeholder(const char *placeholder,`
`993`	`992`	`struct format_commit_context *c)`
`994`	`993`	`{`
`995`	`994`	`const char *ch = placeholder;`
`@@ -1194,7 +1193,7 @@ static size_t format_commit_one(struct strbuf sb, / in UTF-8 */`
`1194`	`1193`
`1195`	`1194`	`case '<':`
`1196`	`1195`	`case '>':`
`1197`		`- return parse_padding_placeholder(sb, placeholder, c);`
	`1196`	`+ return parse_padding_placeholder(placeholder, c);`
`1198`	`1197`	`}`
`1199`	`1198`
`1200`	`1199`	`/* these depend on the commit */`