Skip to content

Commit 97beb81

Browse files
Eric WongJunio C Hamano
authored andcommitted
builtin-log: respect diff configuration options
The log commands are all capable of generating diffs, so we should respect those configuration options for diffs here. Signed-off-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Junio C Hamano <junkio@cox.net>
1 parent be4c701 commit 97beb81

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

builtin-log.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ int cmd_whatchanged(int argc, const char **argv, char **envp)
4747
{
4848
struct rev_info rev;
4949

50+
git_config(git_diff_config);
5051
init_revisions(&rev);
5152
rev.diff = 1;
5253
rev.diffopt.recursive = 1;
@@ -61,6 +62,7 @@ int cmd_show(int argc, const char **argv, char **envp)
6162
{
6263
struct rev_info rev;
6364

65+
git_config(git_diff_config);
6466
init_revisions(&rev);
6567
rev.diff = 1;
6668
rev.diffopt.recursive = 1;
@@ -77,6 +79,7 @@ int cmd_log(int argc, const char **argv, char **envp)
7779
{
7880
struct rev_info rev;
7981

82+
git_config(git_diff_config);
8083
init_revisions(&rev);
8184
rev.always_show_header = 1;
8285
cmd_log_init(argc, argv, envp, &rev);
@@ -102,7 +105,7 @@ static int git_format_config(const char *var, const char *value)
102105
strcat(extra_headers, value);
103106
return 0;
104107
}
105-
return git_default_config(var, value);
108+
return git_diff_config(var, value);
106109
}
107110

108111

@@ -234,6 +237,7 @@ int cmd_format_patch(int argc, const char **argv, char **envp)
234237
struct diff_options patch_id_opts;
235238
char *add_signoff = NULL;
236239

240+
git_config(git_format_config);
237241
init_revisions(&rev);
238242
rev.commit_format = CMIT_FMT_EMAIL;
239243
rev.verbose_header = 1;
@@ -243,7 +247,6 @@ int cmd_format_patch(int argc, const char **argv, char **envp)
243247
rev.diffopt.msg_sep = "";
244248
rev.diffopt.recursive = 1;
245249

246-
git_config(git_format_config);
247250
rev.extra_headers = extra_headers;
248251

249252
/*

0 commit comments

Comments
 (0)