plug a few leaks in revision walking used in describe.

Junio C Hamano · Junio C Hamano · commit 94d23673e371 · 2007-01-11T18:05:53.000-08:00
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/builtin-describe.c b/builtin-describe.c
@@ -183,6 +183,7 @@ static void describe(const char *arg, int last_one)
 			cur_match->depth++;
 		if (!min_match || cur_match->depth < min_match->depth)
 			min_match = cur_match;
+		free_commit_list(revs.commits);
 	}
 	printf("%s-g%s\n", min_match->name->path,
 		   find_unique_abbrev(cmit->object.sha1, abbrev));
diff --git a/revision.c b/revision.c
@@ -1121,21 +1121,23 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch
 void prepare_revision_walk(struct rev_info *revs)
 {
 	int nr = revs->pending.nr;
-	struct object_array_entry *list = revs->pending.objects;
+	struct object_array_entry *e, *list;
 
+	e = list = revs->pending.objects;
 	revs->pending.nr = 0;
 	revs->pending.alloc = 0;
 	revs->pending.objects = NULL;
 	while (--nr >= 0) {
-		struct commit *commit = handle_commit(revs, list->item, list->name);
+		struct commit *commit = handle_commit(revs, e->item, e->name);
 		if (commit) {
 			if (!(commit->object.flags & SEEN)) {
 				commit->object.flags |= SEEN;
 				insert_by_date(commit, &revs->commits);
 			}
 		}
-		list++;
+		e++;
 	}
+	free(list);
 
 	if (revs->no_walk)
 		return;

Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,7 @@ static void describe(const char *arg, int last_one)`
`183`	`183`	`cur_match->depth++;`
`184`	`184`	`if (!min_match \|\| cur_match->depth < min_match->depth)`
`185`	`185`	`min_match = cur_match;`
	`186`	`+ free_commit_list(revs.commits);`
`186`	`187`	`}`
`187`	`188`	`printf("%s-g%s\n", min_match->name->path,`
`188`	`189`	`find_unique_abbrev(cmit->object.sha1, abbrev));`