tests: fix a memory leak in test-oidtree.c

avar · gitster · commit 926d2330357a · 2021-10-07T15:40:15.000-07:00
Fix a memory leak in t/helper/test-oidtree.c, we were not freeing the "struct strbuf" we used for the stdin input we parsed. This leak has been here ever since 92d8ed8 (oidtree: a crit-bit tree for odb_loose_cache, 2021-07-07). Now that it's fixed we can declare that t0069-oidtree.sh will pass under GIT_TEST_PASSING_SANITIZE_LEAK=true. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/t/helper/test-oidtree.c b/t/helper/test-oidtree.c
@@ -45,5 +45,8 @@ int cmd__oidtree(int argc, const char **argv)
 			die("unknown command: %s", line.buf);
 		}
 	}
+
+	strbuf_release(&line);
+
 	return 0;
 }
diff --git a/t/t0069-oidtree.sh b/t/t0069-oidtree.sh
@@ -1,6 +1,7 @@
 #!/bin/sh
 
 test_description='basic tests for the oidtree implementation'
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 maxhexsz=$(test_oid hexsz)

Original file line number	Diff line number	Diff line change
`@@ -45,5 +45,8 @@ int cmd__oidtree(int argc, const char **argv)`
`45`	`45`	`die("unknown command: %s", line.buf);`
`46`	`46`	`}`
`47`	`47`	`}`
	`48`	`+`
	`49`	`+ strbuf_release(&line);`
	`50`	`+`
`48`	`51`	`return 0;`
`49`	`52`	`}`