[PATCH] possible memory leak in diff.c::diff_free_filepair()

yashi · Junio C Hamano · commit 90a734dc7f37 · 2005-08-21T03:48:33.000-07:00
Here is a patch to fix the problem in the simplest way.
diff --git a/diff.c b/diff.c
@@ -1010,9 +1010,8 @@ void diff_flush(int diff_output_style, int line_termination)
 			diff_flush_name(p, line_termination);
 			break;
 		}
-	}
-	for (i = 0; i < q->nr; i++)
 		diff_free_filepair(q->queue[i]);
+	}
 	free(q->queue);
 	q->queue = NULL;
 	q->nr = q->alloc = 0;
