clear_packed_ref_cache(): don't protest if the lock is held

mhagger · gitster · commit 9051198214d3 · 2017-06-23T13:27:33.000-07:00
The existing callers already check that the lock isn't held just
before calling `clear_packed_ref_cache()`, and in the near future we
want to be able to call this function when the lock is held.

Signed-off-by: Michael Haggerty &lt;mhagger@alum.mit.edu&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/refs/packed-backend.c b/refs/packed-backend.c
@@ -133,8 +133,6 @@ static void clear_packed_ref_cache(struct packed_ref_store *refs)
 	if (refs->cache) {
 		struct packed_ref_cache *cache = refs->cache;
 
-		if (is_lock_file_locked(&refs->lock))
-			die("BUG: packed-ref cache cleared while locked");
 		refs->cache = NULL;
 		release_packed_ref_cache(cache);
 	}

Original file line number	Diff line number	Diff line change
`@@ -133,8 +133,6 @@ static void clear_packed_ref_cache(struct packed_ref_store *refs)`
`133`	`133`	`if (refs->cache) {`
`134`	`134`	`struct packed_ref_cache *cache = refs->cache;`
`135`	`135`
`136`		`- if (is_lock_file_locked(&refs->lock))`
`137`		`- die("BUG: packed-ref cache cleared while locked");`
`138`	`136`	`refs->cache = NULL;`
`139`	`137`	`release_packed_ref_cache(cache);`
`140`	`138`	`}`