t3701: fix here document

gitster · gitster · commit 8fe6177ac640 · 2011-05-05T11:28:52.000-07:00
A broken here-document was not caught because end of file is taken by
an implicit end of the here document (POSIX does not seem to say it is
an error to lack the delimiter), and everything in the test just turned
into a single "cat into a file".

Noticed-by: Kacper Kornet &lt;draenog@pld-linux.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh
@@ -82,10 +82,9 @@ EOF
 '
 
 test_expect_success PERL 'setup fake editor' '
-	cat >fake_editor.sh <<EOF
-	EOF
+	>fake_editor.sh &&
 	chmod a+x fake_editor.sh &&
-	test_set_editor "$(pwd)/fake_editor.sh" &&
+	test_set_editor "$(pwd)/fake_editor.sh"
 '
 
 test_expect_success PERL 'dummy edit works' '

Original file line number	Diff line number	Diff line change
`@@ -82,10 +82,9 @@ EOF`
`82`	`82`	`'`
`83`	`83`
`84`	`84`	`test_expect_success PERL 'setup fake editor' '`
`85`		`- cat >fake_editor.sh <<EOF`
`86`		`- EOF`
	`85`	`+ >fake_editor.sh &&`
`87`	`86`	`chmod a+x fake_editor.sh &&`
`88`		`- test_set_editor "$(pwd)/fake_editor.sh" &&`
	`87`	`+ test_set_editor "$(pwd)/fake_editor.sh"`
`89`	`88`	`'`
`90`	`89`
`91`	`90`	`test_expect_success PERL 'dummy edit works' '`