Move post-update hook to after all other activity

spearce · Junio C Hamano · commit 8e663d9e90d3 · 2007-03-07T14:45:40.000-08:00
As the post-update hook is meant to run after we have completed the
receipt of the pushed changes, and it might actually try to kick off
a `repack -a -d`, we should delay on invoking it until after we have
removed the *.keep file on the uploaded pack (if we kept the pack).

Signed-off-by: Shawn O. Pearce &lt;spearce@spearce.org&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/receive-pack.c b/receive-pack.c
@@ -206,12 +206,10 @@ static void run_update_post_hook(struct command *cmd)
 static void execute_commands(void)
 {
 	struct command *cmd = commands;
-
 	while (cmd) {
 		update(cmd);
 		cmd = cmd->next;
 	}
-	run_update_post_hook(commands);
 }
 
 static void read_head_info(void)
@@ -456,6 +454,7 @@ int main(int argc, char **argv)
 			unlink(pack_lockfile);
 		if (report_status)
 			report(unpack_status);
+		run_update_post_hook(commands);
 	}
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -206,12 +206,10 @@ static void run_update_post_hook(struct command *cmd)`
`206`	`206`	`static void execute_commands(void)`
`207`	`207`	`{`
`208`	`208`	`struct command *cmd = commands;`
`209`		`-`
`210`	`209`	`while (cmd) {`
`211`	`210`	`update(cmd);`
`212`	`211`	`cmd = cmd->next;`
`213`	`212`	`}`
`214`		`- run_update_post_hook(commands);`
`215`	`213`	`}`
`216`	`214`
`217`	`215`	`static void read_head_info(void)`
`@@ -456,6 +454,7 @@ int main(int argc, char **argv)`
`456`	`454`	`unlink(pack_lockfile);`
`457`	`455`	`if (report_status)`
`458`	`456`	`report(unpack_status);`
	`457`	`+ run_update_post_hook(commands);`
`459`	`458`	`}`
`460`	`459`	`return 0;`
`461`	`460`	`}`