t5551: test usage of chunked encoding explicitly

jonathantanmy · gitster · commit 8d45ad8c29dd · 2019-06-27T10:14:10.000-07:00
When run using GIT_TEST_PROTOCOL_VERSION=2, a test in t5551 fails
because 4 POSTs (probe, ls-refs, probe, fetch) are sent instead of 2
(probe, fetch).

One way to resolve this would be to relax the condition (from "= 2" to
greater than 1, say), but upon further inspection, the test probably
shouldn't be counting the number of POSTs. This test states that large
requests are split across POSTs, but this is not correct; the main
change is that chunked transfer encoding is used, but the request is
still contained within one POST. (The test coincidentally works because
Git indeed sends 2 POSTs in the case of a large request, but that is
because, as stated above, the first POST is a probing RPC - see
post_rpc() in remote-curl.c for more information.)

Therefore, instead of counting POSTs, check that chunked transfer
encoding is used. This also has the desirable side effect of passing
with GIT_TEST_PROTOCOL_VERSION=2.

Signed-off-by: Jonathan Tan &lt;jonathantanmy@google.com&gt;
Acked-by: Derrick Stolee &lt;dstolee@microsoft.com&gt;
Acked-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
@@ -272,11 +272,10 @@ test_expect_success CMDLINE_LIMIT \
 	)
 '
 
-test_expect_success 'large fetch-pack requests can be split across POSTs' '
+test_expect_success 'large fetch-pack requests can be sent using chunked encoding' '
 	GIT_TRACE_CURL=true git -c http.postbuffer=65536 \
 		clone --bare "$HTTPD_URL/smart/repo.git" split.git 2>err &&
-	grep "^=> Send header: POST" err >posts &&
-	test_line_count = 2 posts
+	grep "^=> Send header: Transfer-Encoding: chunked" err
 '
 
 test_expect_success 'test allowreachablesha1inwant' '

Original file line number	Diff line number	Diff line change
`@@ -272,11 +272,10 @@ test_expect_success CMDLINE_LIMIT \`
`272`	`272`	`)`
`273`	`273`	`'`
`274`	`274`
`275`		`-test_expect_success 'large fetch-pack requests can be split across POSTs' '`
	`275`	`+test_expect_success 'large fetch-pack requests can be sent using chunked encoding' '`
`276`	`276`	`GIT_TRACE_CURL=true git -c http.postbuffer=65536 \`
`277`	`277`	`clone --bare "$HTTPD_URL/smart/repo.git" split.git 2>err &&`
`278`		`- grep "^=> Send header: POST" err >posts &&`
`279`		`- test_line_count = 2 posts`
	`278`	`+ grep "^=> Send header: Transfer-Encoding: chunked" err`
`280`	`279`	`'`
`281`	`280`
`282`	`281`	`test_expect_success 'test allowreachablesha1inwant' '`