git fetch-pack: do not complain about "no common commits" in an empty repo

dscho · gitster · commit 8cb560fc470e · 2008-07-02T11:54:22.000-07:00
If the repo is empty, it is obvious that there are no common commits
when fetching from _anywhere_.

So there is no use in saying it in that case, and it can even be
annoying.  Therefore suppress the message unilaterally if the repository
is empty prior to the fetch.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin-fetch-pack.c b/builtin-fetch-pack.c
@@ -309,7 +309,8 @@ static int find_common(int fd[2], unsigned char *result_sha1,
 		}
 		flushes--;
 	}
-	return retval;
+	/* it is no error to fetch into a completely empty repo */
+	return count ? retval : 0;
 }
 
 static struct commit_list *complete;

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,8 @@ static int find_common(int fd[2], unsigned char *result_sha1,`
`309`	`309`	`}`
`310`	`310`	`flushes--;`
`311`	`311`	`}`
`312`		`- return retval;`
	`312`	`+ /* it is no error to fetch into a completely empty repo */`
	`313`	`+ return count ? retval : 0;`
`313`	`314`	`}`
`314`	`315`
`315`	`316`	`static struct commit_list *complete;`