describe: do not silently ignore indescribable commits

Junio C Hamano · Junio C Hamano · commit 8c23b6fae2e5 · 2006-01-11T13:41:25.000-08:00
We silently ignored indescribable commits without complaining.
Complain and die instead.

Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/describe.c b/describe.c
@@ -124,10 +124,11 @@ static void describe(struct commit *cmit)
 		if (n) {
 			printf("%s-g%s\n", n->path,
 			       find_unique_abbrev(cmit->object.sha1, abbrev));
-			break;
+			clear_commit_marks(cmit, SEEN);
+			return;
 		}
 	}
-	clear_commit_marks(cmit, SEEN);
+	die("cannot describe '%s'", sha1_to_hex(cmit->object.sha1));
 }
 
 int main(int argc, char **argv)

Original file line number	Diff line number	Diff line change
`@@ -124,10 +124,11 @@ static void describe(struct commit *cmit)`
`124`	`124`	`if (n) {`
`125`	`125`	`printf("%s-g%s\n", n->path,`
`126`	`126`	`find_unique_abbrev(cmit->object.sha1, abbrev));`
`127`		`- break;`
	`127`	`+ clear_commit_marks(cmit, SEEN);`
	`128`	`+ return;`
`128`	`129`	`}`
`129`	`130`	`}`
`130`		`- clear_commit_marks(cmit, SEEN);`
	`131`	`+ die("cannot describe '%s'", sha1_to_hex(cmit->object.sha1));`
`131`	`132`	`}`
`132`	`133`
`133`	`134`	`int main(int argc, char **argv)`