Don't rely on unspecified behavior

tschwinge · gitster · commit 8b4aee015e2d · 2007-07-28T18:50:36.000-07:00
Calling access(p, m) with p == NULL is not specified, so don't do that.  On
GNU/Hurd systems doing so will result in a SIGSEGV.

Signed-off-by: Thomas Schwinge &lt;tschwinge@gnu.org&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin-add.c b/builtin-add.c
@@ -60,7 +60,7 @@ static void fill_directory(struct dir_struct *dir, const char **pathspec,
 		path = git_path("info/exclude");
 		if (!access(path, R_OK))
 			add_excludes_from_file(dir, path);
-		if (!access(excludes_file, R_OK))
+		if (excludes_file != NULL && !access(excludes_file, R_OK))
 			add_excludes_from_file(dir, excludes_file);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ static void fill_directory(struct dir_struct dir, const char *pathspec,`
`60`	`60`	`path = git_path("info/exclude");`
`61`	`61`	`if (!access(path, R_OK))`
`62`	`62`	`add_excludes_from_file(dir, path);`
`63`		`- if (!access(excludes_file, R_OK))`
	`63`	`+ if (excludes_file != NULL && !access(excludes_file, R_OK))`
`64`	`64`	`add_excludes_from_file(dir, excludes_file);`
`65`	`65`	`}`
`66`	`66`