Skip to content

Commit 88d9405

Browse files
author
Junio C Hamano
committed
Merge branch 'jc/name' into next
* jc/name: sha1_name: make core.warnambiguousrefs the default. sha1_name: warning ambiguous refs.
2 parents dcd0409 + 1b371f5 commit 88d9405

File tree

13 files changed

+16
-4
lines changed

13 files changed

+16
-4
lines changed

blame.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -752,6 +752,7 @@ int main(int argc, const char **argv)
752752
int found_rename;
753753

754754
const char* prefix = setup_git_directory();
755+
git_config(git_default_config);
755756

756757
for(i = 1; i < argc; i++) {
757758
if(options) {

cat-file.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ int main(int argc, char **argv)
100100
int opt;
101101

102102
setup_git_directory();
103+
git_config(git_default_config);
103104
if (argc != 3 || get_sha1(argv[2], sha1))
104105
usage("git-cat-file [-t|-s|-e|-p|<type>] <sha1>");
105106

environment.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ char git_default_name[MAX_GITNAME];
1414
int trust_executable_bit = 1;
1515
int assume_unchanged = 0;
1616
int only_use_symrefs = 0;
17-
int warn_ambiguous_refs = 0;
17+
int warn_ambiguous_refs = 1;
1818
int repository_format_version = 0;
1919
char git_commit_encoding[MAX_ENCODING_LENGTH] = "utf-8";
2020
int shared_repository = 0;

ls-tree.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ int main(int argc, const char **argv)
9090
struct tree *tree;
9191

9292
prefix = setup_git_directory();
93+
git_config(git_default_config);
9394
if (prefix && *prefix)
9495
chomp_prefix = strlen(prefix);
9596
while (1 < argc && argv[1][0] == '-') {

merge-base.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ int main(int argc, char **argv)
237237
unsigned char rev1key[20], rev2key[20];
238238

239239
setup_git_directory();
240+
git_config(git_default_config);
240241

241242
while (1 < argc && argv[1][0] == '-') {
242243
char *arg = argv[1];

name-rev.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ int main(int argc, char **argv)
127127
int as_is = 0, all = 0, transform_stdin = 0;
128128

129129
setup_git_directory();
130+
git_config(git_default_config);
130131

131132
if (argc < 2)
132133
usage(name_rev_usage);

read-tree.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -717,6 +717,7 @@ int main(int argc, char **argv)
717717
merge_fn_t fn = NULL;
718718

719719
setup_git_directory();
720+
git_config(git_default_config);
720721

721722
newfd = hold_index_file_for_update(&cache_file, get_index_file());
722723
if (newfd < 0)

rev-parse.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,8 @@ int main(int argc, char **argv)
166166
unsigned char sha1[20];
167167
const char *prefix = setup_git_directory();
168168

169+
git_config(git_default_config);
170+
169171
for (i = 1; i < argc; i++) {
170172
struct stat st;
171173
char *arg = argv[i];

send-pack.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,8 @@ int main(int argc, char **argv)
362362
pid_t pid;
363363

364364
setup_git_directory();
365+
git_config(git_default_config);
366+
365367
argv++;
366368
for (i = 1; i < argc; i++, argv++) {
367369
char *arg = *argv;

sha1_name.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ static int ambiguous_path(const char *path, int len)
236236
static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
237237
{
238238
static const char *fmt[] = {
239-
"/%.*s",
239+
"%.*s",
240240
"refs/%.*s",
241241
"refs/tags/%.*s",
242242
"refs/heads/%.*s",
@@ -263,8 +263,7 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
263263
pathname = git_path(*p, len, str);
264264
if (!read_ref(pathname, this_result)) {
265265
if (warn_ambiguous_refs) {
266-
if (already_found &&
267-
!memcmp(sha1, sha1_from_ref, 20))
266+
if (already_found)
268267
fprintf(stderr, warning, len, str);
269268
already_found++;
270269
}

0 commit comments

Comments
 (0)