refs/packet: add missing BUG() invocations to reflog callbacks

avar · gitster · commit 881aebffcffb · 2021-08-19T19:06:38.000-07:00
In e0cc8ac (packed_ref_store: make class into a subclass of `ref_store`, 2017-06-23) a die() was added to packed_create_reflog(), but not to any of the other reflog callbacks, let's do that. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/refs/packed-backend.c b/refs/packed-backend.c
@@ -1600,6 +1600,7 @@ static int packed_for_each_reflog_ent(struct ref_store *ref_store,
 				      const char *refname,
 				      each_reflog_ent_fn fn, void *cb_data)
 {
+	BUG("packed reference store does not support reflogs");
 	return 0;
 }
 
@@ -1608,12 +1609,14 @@ static int packed_for_each_reflog_ent_reverse(struct ref_store *ref_store,
 					      each_reflog_ent_fn fn,
 					      void *cb_data)
 {
+	BUG("packed reference store does not support reflogs");
 	return 0;
 }
 
 static int packed_reflog_exists(struct ref_store *ref_store,
 			       const char *refname)
 {
+	BUG("packed reference store does not support reflogs");
 	return 0;
 }
 
@@ -1627,6 +1630,7 @@ static int packed_create_reflog(struct ref_store *ref_store,
 static int packed_delete_reflog(struct ref_store *ref_store,
 			       const char *refname)
 {
+	BUG("packed reference store does not support reflogs");
 	return 0;
 }
 
@@ -1638,6 +1642,7 @@ static int packed_reflog_expire(struct ref_store *ref_store,
 				reflog_expiry_cleanup_fn cleanup_fn,
 				void *policy_cb_data)
 {
+	BUG("packed reference store does not support reflogs");
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1600,6 +1600,7 @@ static int packed_for_each_reflog_ent(struct ref_store *ref_store,`
`1600`	`1600`	`const char *refname,`
`1601`	`1601`	`each_reflog_ent_fn fn, void *cb_data)`
`1602`	`1602`	`{`
	`1603`	`+ BUG("packed reference store does not support reflogs");`
`1603`	`1604`	`return 0;`
`1604`	`1605`	`}`
`1605`	`1606`
`@@ -1608,12 +1609,14 @@ static int packed_for_each_reflog_ent_reverse(struct ref_store *ref_store,`
`1608`	`1609`	`each_reflog_ent_fn fn,`
`1609`	`1610`	`void *cb_data)`
`1610`	`1611`	`{`
	`1612`	`+ BUG("packed reference store does not support reflogs");`
`1611`	`1613`	`return 0;`
`1612`	`1614`	`}`
`1613`	`1615`
`1614`	`1616`	`static int packed_reflog_exists(struct ref_store *ref_store,`
`1615`	`1617`	`const char *refname)`
`1616`	`1618`	`{`
	`1619`	`+ BUG("packed reference store does not support reflogs");`
`1617`	`1620`	`return 0;`
`1618`	`1621`	`}`
`1619`	`1622`
`@@ -1627,6 +1630,7 @@ static int packed_create_reflog(struct ref_store *ref_store,`
`1627`	`1630`	`static int packed_delete_reflog(struct ref_store *ref_store,`
`1628`	`1631`	`const char *refname)`
`1629`	`1632`	`{`
	`1633`	`+ BUG("packed reference store does not support reflogs");`
`1630`	`1634`	`return 0;`
`1631`	`1635`	`}`
`1632`	`1636`
`@@ -1638,6 +1642,7 @@ static int packed_reflog_expire(struct ref_store *ref_store,`
`1638`	`1642`	`reflog_expiry_cleanup_fn cleanup_fn,`
`1639`	`1643`	`void *policy_cb_data)`
`1640`	`1644`	`{`
	`1645`	`+ BUG("packed reference store does not support reflogs");`
`1641`	`1646`	`return 0;`
`1642`	`1647`	`}`
`1643`	`1648`