t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expression

drafnel · gitster · commit 832ac79edf0e · 2010-06-21T11:11:11.000-07:00
Regular expressions matched by 'expr' have an implicit '^' at the beginning
of them and so are anchored to the beginning of the string.  Using the '^'
character to mean "match at the beginning", is redundant and could produce
the wrong result if 'expr' implementations interpret the '^' as a literal
'^'.  Additionally, GNU expr 5.97 complains like this:

   expr: warning: unportable BRE: `^[a-z][a-z]*$': using `^' as the first character of the basic regular expression is not portable; it is being ignored

Signed-off-by: Brandon Casey &lt;casey@nrlssc.navy.mil&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/lib-pager.sh b/t/lib-pager.sh
@@ -9,7 +9,7 @@ test_expect_success 'determine default pager' '
 	test -n "$less"
 '
 
-if expr "$less" : '^[a-z][a-z]*$' >/dev/null
+if expr "$less" : '[a-z][a-z]*$' >/dev/null
 then
 	test_set_prereq SIMPLEPAGER
 fi

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ test_expect_success 'determine default pager' '`
`9`	`9`	`test -n "$less"`
`10`	`10`	`'`
`11`	`11`
`12`		`-if expr "$less" : '^[a-z][a-z]*$' >/dev/null`
	`12`	`+if expr "$less" : '[a-z][a-z]*$' >/dev/null`
`13`	`13`	`then`
`14`	`14`	`test_set_prereq SIMPLEPAGER`
`15`	`15`	`fi`