t8001/t8002: blame: demonstrate acceptance of bogus -L,+0 and -L,-0

sunshineco · gitster · commit 82cd7e5d3e56 · 2013-08-05T11:54:32.000-07:00
Empty ranges -L,+0 and -L,-0 are nonsensical in the context of blame yet
they are accepted. They should be errors. Demonstrate this shortcoming.

Signed-off-by: Eric Sunshine &lt;sunshine@sunshineco.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/annotate-tests.sh b/t/annotate-tests.sh
@@ -185,6 +185,10 @@ test_expect_success 'blame -L Y,X (undocumented)' '
 	check_count -L6,3 B 1 B1 1 B2 1 D 1
 '
 
+test_expect_failure 'blame -L ,+0' '
+	test_must_fail $PROG -L,+0 file
+'
+
 test_expect_success 'blame -L X,+0' '
 	test_must_fail $PROG -L1,+0 file
 '
@@ -197,6 +201,10 @@ test_expect_success 'blame -L X,+N' '
 	check_count -L3,+4 B 1 B1 1 B2 1 D 1
 '
 
+test_expect_failure 'blame -L ,-0' '
+	test_must_fail $PROG -L,-0 file
+'
+
 test_expect_success 'blame -L X,-0' '
 	test_must_fail $PROG -L1,-0 file
 '

Original file line number	Diff line number	Diff line change
`@@ -185,6 +185,10 @@ test_expect_success 'blame -L Y,X (undocumented)' '`
`185`	`185`	`check_count -L6,3 B 1 B1 1 B2 1 D 1`
`186`	`186`	`'`
`187`	`187`
	`188`	`+test_expect_failure 'blame -L ,+0' '`
	`189`	`+ test_must_fail $PROG -L,+0 file`
	`190`	`+'`
	`191`	`+`
`188`	`192`	`test_expect_success 'blame -L X,+0' '`
`189`	`193`	`test_must_fail $PROG -L1,+0 file`
`190`	`194`	`'`
`@@ -197,6 +201,10 @@ test_expect_success 'blame -L X,+N' '`
`197`	`201`	`check_count -L3,+4 B 1 B1 1 B2 1 D 1`
`198`	`202`	`'`
`199`	`203`
	`204`	`+test_expect_failure 'blame -L ,-0' '`
	`205`	`+ test_must_fail $PROG -L,-0 file`
	`206`	`+'`
	`207`	`+`
`200`	`208`	`test_expect_success 'blame -L X,-0' '`
`201`	`209`	`test_must_fail $PROG -L1,-0 file`
`202`	`210`	`'`