tests: add lint for non portable cp -a

carenas · gitster · commit 82cbc8cde258 · 2018-12-03T09:26:02.000+09:00
cp -a, while a common flag isn't in POSIX and will therefore fail
on systems that don't have GNUish tools (like OpenBSD, AIX or Solaris)

Signed-off-by: Carlo Marcelo Arenas Belón &lt;carenas@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
@@ -35,6 +35,7 @@ sub err {
 		chomp;
 	}
 
+	/\bcp\s+-a/ and err 'cp -a is not portable';
 	/\bsed\s+-i/ and err 'sed -i is not portable';
 	/\becho\s+-[neE]/ and err 'echo with option is not portable (use printf)';
 	/^\s*declare\s+/ and err 'arrays/declare not portable';

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ sub err {`
`35`	`35`	`chomp;`
`36`	`36`	`}`
`37`	`37`
	`38`	`+ /\bcp\s+-a/ and err 'cp -a is not portable';`
`38`	`39`	`/\bsed\s+-i/ and err 'sed -i is not portable';`
`39`	`40`	`/\becho\s+-[neE]/ and err 'echo with option is not portable (use printf)';`
`40`	`41`	`/^\s*declare\s+/ and err 'arrays/declare not portable';`