completion: bash: cleanup cygwin check

felipec · gitster · commit 8030684beb7a · 2020-10-28T14:30:59.000-07:00
Avoid Yoda conditions, and use $OSTYPE.

Signed-off-by: Felipe Contreras &lt;felipe.contreras@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
@@ -3499,6 +3499,6 @@ __git_complete gitk __gitk_main
 # when the user has tab-completed the executable name and consequently
 # included the '.exe' suffix.
 #
-if [ Cygwin = "$(uname -o 2>/dev/null)" ]; then
-__git_complete git.exe __git_main
+if [ "$OSTYPE" = cygwin ]; then
+	__git_complete git.exe __git_main
 fi

Original file line number	Diff line number	Diff line change
`@@ -3499,6 +3499,6 @@ __git_complete gitk __gitk_main`
`3499`	`3499`	`# when the user has tab-completed the executable name and consequently`
`3500`	`3500`	`# included the '.exe' suffix.`
`3501`	`3501`	`#`
`3502`		`-if [ Cygwin = "$(uname -o 2>/dev/null)" ]; then`
`3503`		`-__git_complete git.exe __git_main`
	`3502`	`+if [ "$OSTYPE" = cygwin ]; then`
	`3503`	`+ __git_complete git.exe __git_main`
`3504`	`3504`	`fi`