prefer xwrite instead of write

kusma · gitster · commit 7edc02f4deed · 2014-01-17T12:09:26.000-08:00
Our xwrite wrapper already deals with a few potential hazards, and
are as such more robust. Prefer it instead of write to get the
robustness benefits everywhere.

Signed-off-by: Erik Faye-Lund &lt;kusmabite@gmail.com&gt;
Reviewed-and-improved-by: Jonathan Nieder &lt;jrnieder@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/merge.c b/builtin/merge.c
@@ -367,7 +367,7 @@ static void squash_message(struct commit *commit, struct commit_list *remotehead
 			sha1_to_hex(commit->object.sha1));
 		pretty_print_commit(&ctx, commit, &out);
 	}
-	if (write(fd, out.buf, out.len) < 0)
+	if (write_in_full(fd, out.buf, out.len) != out.len)
 		die_errno(_("Writing SQUASH_MSG"));
 	if (close(fd))
 		die_errno(_("Finishing SQUASH_MSG"));
diff --git a/streaming.c b/streaming.c
@@ -538,7 +538,7 @@ int stream_blob_to_fd(int fd, unsigned const char *sha1, struct stream_filter *f
 			goto close_and_exit;
 	}
 	if (kept && (lseek(fd, kept - 1, SEEK_CUR) == (off_t) -1 ||
-		     write(fd, "", 1) != 1))
+		     xwrite(fd, "", 1) != 1))
 		goto close_and_exit;
 	result = 0;
 
diff --git a/transport-helper.c b/transport-helper.c
@@ -1129,9 +1129,8 @@ static int udt_do_write(struct unidirectional_transfer *t)
 		return 0;	/* Nothing to write. */
 
 	transfer_debug("%s is writable", t->dest_name);
-	bytes = write(t->dest, t->buf, t->bufuse);
-	if (bytes < 0 && errno != EWOULDBLOCK && errno != EAGAIN &&
-		errno != EINTR) {
+	bytes = xwrite(t->dest, t->buf, t->bufuse);
+	if (bytes < 0 && errno != EWOULDBLOCK) {
 		error("write(%s) failed: %s", t->dest_name, strerror(errno));
 		return -1;
 	} else if (bytes > 0) {

Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,7 @@ static void squash_message(struct commit commit, struct commit_list remotehead`
`367`	`367`	`sha1_to_hex(commit->object.sha1));`
`368`	`368`	`pretty_print_commit(&ctx, commit, &out);`
`369`	`369`	`}`
`370`		`- if (write(fd, out.buf, out.len) < 0)`
	`370`	`+ if (write_in_full(fd, out.buf, out.len) != out.len)`
`371`	`371`	`die_errno(_("Writing SQUASH_MSG"));`
`372`	`372`	`if (close(fd))`
`373`	`373`	`die_errno(_("Finishing SQUASH_MSG"));`
Original file line number	Diff line number	Diff line change
`@@ -538,7 +538,7 @@ int stream_blob_to_fd(int fd, unsigned const char sha1, struct stream_filter f`
`538`	`538`	`goto close_and_exit;`
`539`	`539`	`}`
`540`	`540`	`if (kept && (lseek(fd, kept - 1, SEEK_CUR) == (off_t) -1 \|\|`
`541`		`- write(fd, "", 1) != 1))`
	`541`	`+ xwrite(fd, "", 1) != 1))`
`542`	`542`	`goto close_and_exit;`
`543`	`543`	`result = 0;`
`544`	`544`