Add output flushing before fork()

Anders Melchiorsen · gitster · commit 7d0b18a4da1b · 2008-08-04T21:46:42.000-07:00
This adds fflush(NULL) before fork() in start_command(), to keep
the generic interface safe.

A remaining use of fork() with no flushing is in a comment in
show_tree(). Rewrite that comment to use start_command().

Signed-off-by: Anders Melchiorsen &lt;mail@cup.kalibalik.dk&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin-ls-tree.c b/builtin-ls-tree.c
@@ -66,17 +66,16 @@ static int show_tree(const unsigned char *sha1, const char *base, int baselen,
 		/*
 		 * Maybe we want to have some recursive version here?
 		 *
-		 * Something like:
+		 * Something similar to this incomplete example:
 		 *
 		if (show_subprojects(base, baselen, pathname)) {
-			if (fork()) {
-				chdir(base);
-				exec ls-tree;
-			}
-			waitpid();
+			struct child_process ls_tree;
+
+			ls_tree.dir = base;
+			ls_tree.argv = ls-tree;
+			start_command(&ls_tree);
 		}
 		 *
-		 * ..or similar..
 		 */
 		type = commit_type;
 	} else if (S_ISDIR(mode)) {
diff --git a/run-command.c b/run-command.c
@@ -68,6 +68,7 @@ int start_command(struct child_process *cmd)
 	trace_argv_printf(cmd->argv, "trace: run_command:");
 
 #ifndef __MINGW32__
+	fflush(NULL);
 	cmd->pid = fork();
 	if (!cmd->pid) {
 		if (cmd->no_stdin)

Original file line number	Diff line number	Diff line change
`@@ -66,17 +66,16 @@ static int show_tree(const unsigned char sha1, const char base, int baselen,`
`66`	`66`	`/*`
`67`	`67`	`* Maybe we want to have some recursive version here?`
`68`	`68`	`*`
`69`		`- * Something like:`
	`69`	`+ * Something similar to this incomplete example:`
`70`	`70`	`*`
`71`	`71`	`if (show_subprojects(base, baselen, pathname)) {`
`72`		`- if (fork()) {`
`73`		`- chdir(base);`
`74`		`- exec ls-tree;`
`75`		`- }`
`76`		`- waitpid();`
	`72`	`+ struct child_process ls_tree;`
	`73`	`+`
	`74`	`+ ls_tree.dir = base;`
	`75`	`+ ls_tree.argv = ls-tree;`
	`76`	`+ start_command(&ls_tree);`
`77`	`77`	`}`
`78`	`78`	`*`
`79`		`- * ..or similar..`
`80`	`79`	`*/`
`81`	`80`	`type = commit_type;`
`82`	`81`	`} else if (S_ISDIR(mode)) {`