t7411: quote URLs

stefanbeller · gitster · commit 7af55d1f2bfa · 2017-01-12T14:18:22.000-08:00
The variables may contain white spaces, so we need to quote them.
By not quoting the variables we'd end up passing multiple arguments to
git config, which doesn't fail for two arguments as value.

Signed-off-by: Stefan Beller &lt;sbeller@google.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t7411-submodule-config.sh b/t/t7411-submodule-config.sh
@@ -134,8 +134,8 @@ test_expect_success 'reading of local configuration' '
 			"" submodule \
 				>actual &&
 		test_cmp expect_local_path actual &&
-		git config submodule.a.url $old_a &&
-		git config submodule.submodule.url $old_submodule &&
+		git config submodule.a.url "$old_a" &&
+		git config submodule.submodule.url "$old_submodule" &&
 		git config --unset submodule.a.path c
 	)
 '

Original file line number	Diff line number	Diff line change
`@@ -134,8 +134,8 @@ test_expect_success 'reading of local configuration' '`
`134`	`134`	`"" submodule \`
`135`	`135`	`>actual &&`
`136`	`136`	`test_cmp expect_local_path actual &&`
`137`		`- git config submodule.a.url $old_a &&`
`138`		`- git config submodule.submodule.url $old_submodule &&`
	`137`	`+ git config submodule.a.url "$old_a" &&`
	`138`	`+ git config submodule.submodule.url "$old_submodule" &&`
`139`	`139`	`git config --unset submodule.a.path c`
`140`	`140`	`)`
`141`	`141`	`'`