git-stash: do not remove a ref by hand.

gitster · gitster · commit 7ab3cc70a6aa · 2007-07-26T23:24:28.000-07:00
Somebody on #git noticed that "git stash clear" left a packed
ref behind for ref/stash.

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/git-stash.sh b/git-stash.sh
@@ -19,9 +19,10 @@ no_changes () {
 }
 
 clear_stash () {
-	logfile="$GIT_DIR/logs/$ref_stash" &&
-	mkdir -p "$(dirname "$logfile")" &&
-	: >"$logfile"
+	if current=$(git rev-parse --verify $ref_stash 2>/dev/null)
+	then
+		git update-ref -d refs/stash $current
+	fi
 }
 
 save_stash () {

Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,10 @@ no_changes () {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`clear_stash () {`
`22`		`- logfile="$GIT_DIR/logs/$ref_stash" &&`
`23`		`- mkdir -p "$(dirname "$logfile")" &&`
`24`		`- : >"$logfile"`
	`22`	`+ if current=$(git rev-parse --verify $ref_stash 2>/dev/null)`
	`23`	`+ then`
	`24`	`+ git update-ref -d refs/stash $current`
	`25`	`+ fi`
`25`	`26`	`}`
`26`	`27`
`27`	`28`	`save_stash () {`