t7701: fix ignored exit code inside loop

peff · gitster · commit 76e057dba29a · 2015-03-25T10:24:13.000-07:00
When checking a list of file mtimes, we use a loop and break
out early from the loop if any entry does not match.
However, the exit code of a loop exited via break is always
0, meaning that the test will fail to notice we had a
mismatch. Since the loop is inside a function, we can fix
this by doing an early "return 1".

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t7701-repack-unpack-unreachable.sh b/t/t7701-repack-unpack-unreachable.sh
@@ -57,7 +57,7 @@ compare_mtimes ()
 {
 	read tref rest &&
 	while read t rest; do
-		test "$tref" = "$t" || break
+		test "$tref" = "$t" || return 1
 	done
 }
 

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ compare_mtimes ()`
`57`	`57`	`{`
`58`	`58`	`read tref rest &&`
`59`	`59`	`while read t rest; do`
`60`		`- test "$tref" = "$t" \|\| break`
	`60`	`+ test "$tref" = "$t" \|\| return 1`
`61`	`61`	`done`
`62`	`62`	`}`
`63`	`63`