completion: avoid aliased command lookup error in nounset mode

scop · gitster · commit 76655e8a28d3 · 2021-04-16T13:40:52.000-07:00
Aliased command lookup accesses the `list` variable before it has been
set, causing an error in "nounset" mode. Initialize to an empty string
to avoid that.

    $ git nonexistent-command &lt;Tab&gt;bash: list: unbound variable

Signed-off-by: Ville Skyttä &lt;ville.skytta@iki.fi&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
@@ -1129,7 +1129,7 @@ __git_pretty_aliases ()
 # __git_aliased_command requires 1 argument
 __git_aliased_command ()
 {
-	local cur=$1 last list word cmdline
+	local cur=$1 last list= word cmdline
 
 	while [[ -n "$cur" ]]; do
 		if [[ "$list" == *" $cur "* ]]; then

Original file line number	Diff line number	Diff line change
`@@ -1129,7 +1129,7 @@ __git_pretty_aliases ()`
`1129`	`1129`	`# __git_aliased_command requires 1 argument`
`1130`	`1130`	`__git_aliased_command ()`
`1131`	`1131`	`{`
`1132`		`- local cur=$1 last list word cmdline`
	`1132`	`+ local cur=$1 last list= word cmdline`
`1133`	`1133`
`1134`	`1134`	`while [[ -n "$cur" ]]; do`
`1135`	`1135`	`if [[ "$list" == " $cur " ]]; then`