Skip to content

Commit 756373d

Browse files
author
Junio C Hamano
committed
Revert "Allow branch.*.merge to talk about remote tracking branches."
This reverts commit 80c7977. Back when I committed this, it seemed to be a good idea. People who always use remote tracking branches can optionally use the local name they happen to use to specify what to merge, which meant that I did not have to teach them why we use the name at the remote side every time they are confused. But allowing it seems to break other people's scripts. The real solution is not to allow more ways to express the same thing, but to educate people to use the right syntax. Signed-off-by: Junio C Hamano <junkio@cox.net>
1 parent d1f289c commit 756373d

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

git-parse-remote.sh

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -174,12 +174,8 @@ canon_refs_list_for_fetch () {
174174
else
175175
for merge_branch in $merge_branches
176176
do
177-
if test "$remote" = "$merge_branch" ||
178-
test "$local" = "$merge_branch"
179-
then
180-
dot_prefix=
181-
break
182-
fi
177+
[ "$remote" = "$merge_branch" ] &&
178+
dot_prefix= && break
183179
done
184180
fi
185181
case "$remote" in

0 commit comments

Comments
 (0)