Skip to content

Commit 7495a17

Browse files
felipecgitster
authored andcommitted
rev-parse test: use standard test functions for setup
Save the reader from learning specialized t6* setup functions where familiar commands like test_commit, "git checkout --orphan", and "git merge" will do. While at it, wrap the setup commands in a test assertion so errors can be caught and stray output suppressed when running without --verbose as in other tests. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent c812be9 commit 7495a17

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

t/t6101-rev-parse-parents.sh

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,22 @@
66
test_description='Test git rev-parse with different parent options'
77

88
. ./test-lib.sh
9-
. "$TEST_DIRECTORY"/lib-t6000.sh # t6xxx specific functions
109

1110
test_cmp_rev_output () {
1211
git rev-parse --verify "$1" >expect &&
1312
eval "$2" >actual &&
1413
test_cmp expect actual
1514
}
1615

17-
date >path0
18-
git update-index --add path0
19-
save_tag tree git write-tree
20-
hide_error save_tag start unique_commit "start" tree
21-
save_tag second unique_commit "second" tree -p start
22-
hide_error save_tag start2 unique_commit "start2" tree
23-
save_tag two_parents unique_commit "next" tree -p second -p start2
24-
save_tag final unique_commit "final" tree -p two_parents
16+
test_expect_success 'setup' '
17+
test_commit start &&
18+
test_commit second &&
19+
git checkout --orphan tmp &&
20+
test_commit start2 &&
21+
git checkout master &&
22+
git merge -m next start2 &&
23+
test_commit final
24+
'
2525

2626
test_expect_success 'start is valid' '
2727
git rev-parse start | grep "^[0-9a-f]\{40\}$"

0 commit comments

Comments
 (0)