repository: fix free problem with repo_clear(the_repository)

pclouds · gitster · commit 74373b5f10e2 · 2018-05-10T18:33:09.000+09:00
the_repository is special. One of the special things about it is that
it does not allocate a new index_state object like submodules but
points to the global the_index variable instead. As a global variable,
the_index cannot be free()'d.

Add an exception for this in repo_clear(). In the future perhaps we
would be able to allocate the_repository's index on heap too. Then we
can revert this.

the_repository-&gt;index remains pointed to a clean the_index even after
repo_clear() so that it could still be used next time (e.g. in a crazy
use case where a dev switches repo in the same process).

Signed-off-by: Nguyễn Thái Ngọc Duy &lt;pclouds@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/repository.c b/repository.c
@@ -220,7 +220,8 @@ void repo_clear(struct repository *repo)
 
 	if (repo->index) {
 		discard_index(repo->index);
-		FREE_AND_NULL(repo->index);
+		if (repo->index != &the_index)
+			FREE_AND_NULL(repo->index);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,8 @@ void repo_clear(struct repository *repo)`
`220`	`220`
`221`	`221`	`if (repo->index) {`
`222`	`222`	`discard_index(repo->index);`
`223`		`- FREE_AND_NULL(repo->index);`
	`223`	`+ if (repo->index != &the_index)`
	`224`	`+ FREE_AND_NULL(repo->index);`
`224`	`225`	`}`
`225`	`226`	`}`
`226`	`227`