contrib/git-credential-gnome-keyring.c: ensure buffer is non-empty before accessing

drafnel · gitster · commit 73bbc0796b4c · 2013-10-16T09:35:31.000-07:00
Ensure buffer length is non-zero before attempting to access the last
element.

Signed-off-by: Brandon Casey &lt;drafnel@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
@@ -314,7 +314,7 @@ static int credential_read(struct credential *c)
 	{
 		line_len = strlen(buf);
 
-		if (buf[line_len-1]=='\n')
+		if (line_len && buf[line_len-1] == '\n')
 			buf[--line_len]='\0';
 
 		if (!line_len)

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ static int credential_read(struct credential *c)`
`314`	`314`	`{`
`315`	`315`	`line_len = strlen(buf);`
`316`	`316`
`317`		`- if (buf[line_len-1]=='\n')`
	`317`	`+ if (line_len && buf[line_len-1] == '\n')`
`318`	`318`	`buf[--line_len]='\0';`
`319`	`319`
`320`	`320`	`if (!line_len)`