test-prio-queue: use xmalloc

peff · gitster · commit 73a5faf01765 · 2019-04-12T13:34:17.000+09:00
test-prio-queue.c doesn't check the return value of malloc, and could
segfault.

It's unlikely for this to matter in practice; it's a small allocation,
and this code isn't even installed alongside the rest of Git. But let's
use xmalloc(), which makes auditing for other accidental uses of bare
malloc() easier.

Reported-by: 王健强 &lt;jianqiang.wang@securitygossip.com&gt;
Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/helper/test-prio-queue.c b/t/helper/test-prio-queue.c
@@ -40,7 +40,7 @@ int cmd__prio_queue(int argc, const char **argv)
 		} else if (!strcmp(*argv, "stack")) {
 			pq.compare = NULL;
 		} else {
-			int *v = malloc(sizeof(*v));
+			int *v = xmalloc(sizeof(*v));
 			*v = atoi(*argv);
 			prio_queue_put(&pq, v);
 		}

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ int cmd__prio_queue(int argc, const char **argv)`
`40`	`40`	`} else if (!strcmp(*argv, "stack")) {`
`41`	`41`	`pq.compare = NULL;`
`42`	`42`	`} else {`
`43`		`- int v = malloc(sizeof(v));`
	`43`	`+ int v = xmalloc(sizeof(v));`
`44`	`44`	`v = atoi(argv);`
`45`	`45`	`prio_queue_put(&pq, v);`
`46`	`46`	`}`