help: release strbuf on error return in exec_man_man()

rscharfe · gitster · commit 724621866763 · 2017-09-07T08:49:27.000+09:00
Signed-off-by: Rene Scharfe &lt;l.s.r@web.de&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/help.c b/builtin/help.c
@@ -170,6 +170,7 @@ static void exec_man_cmd(const char *cmd, const char *page)
 	strbuf_addf(&shell_cmd, "%s %s", cmd, page);
 	execl(SHELL_PATH, SHELL_PATH, "-c", shell_cmd.buf, (char *)NULL);
 	warning(_("failed to exec '%s'"), cmd);
+	strbuf_release(&shell_cmd);
 }
 
 static void add_man_viewer(const char *name)

Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,7 @@ static void exec_man_cmd(const char cmd, const char page)`
`170`	`170`	`strbuf_addf(&shell_cmd, "%s %s", cmd, page);`
`171`	`171`	`execl(SHELL_PATH, SHELL_PATH, "-c", shell_cmd.buf, (char *)NULL);`
`172`	`172`	`warning(_("failed to exec '%s'"), cmd);`
	`173`	`+ strbuf_release(&shell_cmd);`
`173`	`174`	`}`
`174`	`175`
`175`	`176`	`static void add_man_viewer(const char *name)`