git-bisect: modernization

Junio C Hamano · Junio C Hamano · commit 6fecf1915c5f · 2007-04-05T22:51:14.000-07:00
This slightly modernizes the bisect script to use show-ref/for-each-ref
instead of looking into $GIT_DIR/refs files directly.

Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/git-bisect.sh b/git-bisect.sh
@@ -169,11 +169,10 @@ bisect_write_good() {
 
 bisect_next_check() {
 	next_ok=no
-        test -f "$GIT_DIR/refs/bisect/bad" &&
-	case "$(cd "$GIT_DIR" && echo refs/bisect/good-*)" in
-	refs/bisect/good-\*) ;;
-	*) next_ok=yes ;;
-	esac
+	git show-ref -q --verify refs/bisect/bad &&
+	test -n "$(git for-each-ref "refs/bisect/good-*")" &&
+	next_ok=yes
+
 	case "$next_ok,$1" in
 	no,) false ;;
 	no,fail)
