shortlog: fix segfault on empty authorname

Junio C Hamano · Junio C Hamano · commit 6f9872582246 · 2006-12-11T14:12:33.000-08:00
The old code looked backwards from the email address to parse the name, allowing an arbitrary number of spaces between the two. However, in the case of no name, we looked back too far to the 'author' (or 'Author:') header. The bug was triggered by commit febf7ea from linux-2.6. Jeff King originally fixed it by looking back only one character; Johannes Schindelin pointed out that we could try harder while at it to cope with commits with broken headers. Signed-off-by: Junio C Hamano <junkio@cox.net>
diff --git a/builtin-shortlog.c b/builtin-shortlog.c
@@ -188,7 +188,8 @@ static void read_from_stdin(struct path_list *list)
 				bob = buffer + strlen(buffer);
 			else {
 				offset = 8;
-				if (isspace(bob[-1]))
+				while (buffer + offset < bob &&
+				       isspace(bob[-1]))
 					bob--;
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,8 @@ static void read_from_stdin(struct path_list *list)`
`188`	`188`	`bob = buffer + strlen(buffer);`
`189`	`189`	`else {`
`190`	`190`	`offset = 8;`
`191`		`- if (isspace(bob[-1]))`
	`191`	`+ while (buffer + offset < bob &&`
	`192`	`+ isspace(bob[-1]))`
`192`	`193`	`bob--;`
`193`	`194`	`}`
`194`	`195`