gitweb: Fix bug in git_difftree_body (was '!=' instead of 'ne')

jnareb · Junio C Hamano · commit 6e72cf43a7b1 · 2007-01-03T12:19:20.000-08:00
Fix bug in git_difftree_body subroutine; it was used '!=' comparison
operator for strings (file type) instead of correct 'ne'.

Signed-off-by: Jakub Narebski &lt;jnareb@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
@@ -2274,7 +2274,7 @@ sub git_difftree_body {
 			my $mode_chnge = "";
 			if ($diff{'from_mode'} != $diff{'to_mode'}) {
 				$mode_chnge = "<span class=\"file_status mode_chnge\">[changed";
-				if ($from_file_type != $to_file_type) {
+				if ($from_file_type ne $to_file_type) {
 					$mode_chnge .= " from $from_file_type to $to_file_type";
 				}
 				if (($from_mode_oct & 0777) != ($to_mode_oct & 0777)) {

Original file line number	Diff line number	Diff line change
`@@ -2274,7 +2274,7 @@ sub git_difftree_body {`
`2274`	`2274`	`my $mode_chnge = "";`
`2275`	`2275`	`if ($diff{'from_mode'} != $diff{'to_mode'}) {`
`2276`	`2276`	`$mode_chnge = "<span class=\"file_status mode_chnge\">[changed";`
`2277`		`- if ($from_file_type != $to_file_type) {`
	`2277`	`+ if ($from_file_type ne $to_file_type) {`
`2278`	`2278`	`$mode_chnge .= " from $from_file_type to $to_file_type";`
`2279`	`2279`	`}`
`2280`	`2280`	`if (($from_mode_oct & 0777) != ($to_mode_oct & 0777)) {`