upload-pack: tighten number parsing at "deepen" lines

pclouds · gitster · commit 6e414e30fd12 · 2016-06-13T14:38:16.000-07:00
Signed-off-by: Nguyễn Thái Ngọc Duy &lt;pclouds@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/upload-pack.c b/upload-pack.c
@@ -645,9 +645,9 @@ static void receive_needs(void)
 			continue;
 		}
 		if (skip_prefix(line, "deepen ", &arg)) {
-			char *end;
+			char *end = NULL;
 			depth = strtol(arg, &end, 0);
-			if (end == arg || depth <= 0)
+			if (!end || *end || depth <= 0)
 				die("Invalid deepen: %s", line);
 			continue;
 		}

Original file line number	Diff line number	Diff line change
`@@ -645,9 +645,9 @@ static void receive_needs(void)`
`645`	`645`	`continue;`
`646`	`646`	`}`
`647`	`647`	`if (skip_prefix(line, "deepen ", &arg)) {`
`648`		`- char *end;`
	`648`	`+ char *end = NULL;`
`649`	`649`	`depth = strtol(arg, &end, 0);`
`650`		`- if (end == arg \|\| depth <= 0)`
	`650`	`+ if (!end \|\| *end \|\| depth <= 0)`
`651`	`651`	`die("Invalid deepen: %s", line);`
`652`	`652`	`continue;`
`653`	`653`	`}`