Skip to content

Commit 6ccca67

Browse files
devzero2000gitster
authored andcommitted
contrib/examples/git-repack.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 1a36552 commit 6ccca67

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

contrib/examples/git-repack.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ case ",$all_into_one," in
6767
,t,)
6868
args= existing=
6969
if [ -d "$PACKDIR" ]; then
70-
for e in `cd "$PACKDIR" && find . -type f -name '*.pack' \
71-
| sed -e 's/^\.\///' -e 's/\.pack$//'`
70+
for e in $(cd "$PACKDIR" && find . -type f -name '*.pack' \
71+
| sed -e 's/^\.\///' -e 's/\.pack$//')
7272
do
7373
if [ -e "$PACKDIR/$e.keep" ]; then
7474
: keep

0 commit comments

Comments
 (0)