builtin-for-each-ref.c::copy_name() - do not overstep the buffer.

gitster · gitster · commit 6b30852ded50 · 2007-09-19T01:54:24.000-07:00
This was introduced during xmemdupz() conversion.

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c
@@ -309,7 +309,7 @@ static const char *copy_line(const char *buf)
 static const char *copy_name(const char *buf)
 {
 	const char *cp;
-	for (cp = buf; *cp != '\n'; cp++) {
+	for (cp = buf; *cp && *cp != '\n'; cp++) {
 		if (!strncmp(cp, " <", 2))
 			return xmemdupz(buf, cp - buf);
 	}

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,7 @@ static const char copy_line(const char buf)`
`309`	`309`	`static const char copy_name(const char buf)`
`310`	`310`	`{`
`311`	`311`	`const char *cp;`
`312`		`- for (cp = buf; *cp != '\n'; cp++) {`
	`312`	`+ for (cp = buf; cp && cp != '\n'; cp++) {`
`313`	`313`	`if (!strncmp(cp, " <", 2))`
`314`	`314`	`return xmemdupz(buf, cp - buf);`
`315`	`315`	`}`