git-rebase: don't ignore unexpected command line arguments

drafnel · gitster · commit 697bc8858114 · 2017-09-19T12:13:09.000+09:00
Currently, git-rebase will silently ignore any unexpected command-line
switches and arguments (the command-line produced by git rev-parse).
This allowed the rev-parse bug, fixed in the preceding commits, to go
unnoticed.  Let's make sure that doesn't happen again.  We shouldn't be
ignoring unexpected arguments.  Let's not.

Signed-off-by: Brandon Casey &lt;drafnel@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/git-rebase.sh b/git-rebase.sh
@@ -348,6 +348,9 @@ do
 		shift
 		break
 		;;
+	*)
+		usage
+		;;
 	esac
 	shift
 done

-Original file line number
+Diff line change
 		shift
 		break
 		;;
 +	*)
 +		usage
 +		;;
 	esac
 	shift
 done