safe_fgets() - even more anal fgets()

Junio C Hamano · Junio C Hamano · commit 687dd75c95f9 · 2006-04-03T23:42:25.000-07:00
This is from Linus -- the previous round forgot to clear error
after EINTR case.

Signed-off-by: Junio C Hamano &lt;junkio@cox.net&gt;
diff --git a/pack-objects.c b/pack-objects.c
@@ -915,9 +915,10 @@ int main(int argc, char **argv)
 				break;
 			if (!ferror(stdin))
 				die("fgets returned NULL, not EOF, not error!");
-			if (errno == EINTR)
-				continue;
-			die("fgets: %s", strerror(errno));
+			if (errno != EINTR)
+				die("fgets: %s", strerror(errno));
+			clearerr(stdin);
+			continue;
 		}
 
 		if (progress_update) {
