record_author_date(): fix memory leak on malformed commit

peff · gitster · commit 6876618ceaaf · 2014-08-27T10:30:42.000-07:00
If we hit the end-of-header without finding an "author"
line, we just return from the function. We should jump to
the fail_exit path to clean up the buffer that we may have
allocated.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/commit.c b/commit.c
@@ -594,7 +594,7 @@ static void record_author_date(struct author_date_slab *author_date,
 		line_end = strchrnul(buf, '\n');
 		if (!skip_prefix(buf, "author ", &ident_line)) {
 			if (!line_end[0] || line_end[1] == '\n')
-				return; /* end of header */
+				goto fail_exit; /* end of header */
 			continue;
 		}
 		if (split_ident_line(&ident,

Original file line number	Diff line number	Diff line change
`@@ -594,7 +594,7 @@ static void record_author_date(struct author_date_slab *author_date,`
`594`	`594`	`line_end = strchrnul(buf, '\n');`
`595`	`595`	`if (!skip_prefix(buf, "author ", &ident_line)) {`
`596`	`596`	`if (!line_end[0] \|\| line_end[1] == '\n')`
`597`		`- return; /* end of header */`
	`597`	`+ goto fail_exit; /* end of header */`
`598`	`598`	`continue;`
`599`	`599`	`}`
`600`	`600`	`if (split_ident_line(&ident,`