bisect: add enum to represent bisect returning codes

mirucam · gitster · commit 680e8a01e57c · 2020-02-19T09:37:14.000-08:00
Since we want to get rid of git-bisect.sh, it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.

Create an enum called `bisect_error` with the bisecting return codes
to use in `bisect.c` libification process.

Change bisect_next_all() to make it return this enum.

Mentored-by: Christian Couder &lt;chriscool@tuxfamily.org&gt;
Signed-off-by: Miriam Rubio &lt;mirucam@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/bisect.c b/bisect.c
@@ -945,7 +945,7 @@ void read_bisect_terms(const char **read_bad, const char **read_good)
  * If no_checkout is non-zero, the bisection process does not
  * checkout the trial commit but instead simply updates BISECT_HEAD.
  */
-int bisect_next_all(struct repository *r, const char *prefix, int no_checkout)
+enum bisect_error bisect_next_all(struct repository *r, const char *prefix, int no_checkout)
 {
 	struct rev_info revs;
 	struct commit_list *tried;
diff --git a/bisect.h b/bisect.h
@@ -31,7 +31,19 @@ struct rev_list_info {
 	const char *header_prefix;
 };
 
-int bisect_next_all(struct repository *r,
+/*
+ * enum bisect_error represents the following return codes:
+ * BISECT_OK: success code. Internally, it means that next
+ * commit has been found (and possibly checked out) and it
+ * should be tested.
+ * BISECT_FAILED error code: default error code.
+ */
+enum bisect_error {
+	BISECT_OK = 0,
+	BISECT_FAILED = -1
+};
+
+enum bisect_error bisect_next_all(struct repository *r,
 		    const char *prefix,
 		    int no_checkout);
 

Original file line number	Diff line number	Diff line change
`@@ -945,7 +945,7 @@ void read_bisect_terms(const char read_bad, const char read_good)`
`945`	`945`	`* If no_checkout is non-zero, the bisection process does not`
`946`	`946`	`* checkout the trial commit but instead simply updates BISECT_HEAD.`
`947`	`947`	`*/`
`948`		`-int bisect_next_all(struct repository r, const char prefix, int no_checkout)`
	`948`	`+enum bisect_error bisect_next_all(struct repository r, const char prefix, int no_checkout)`
`949`	`949`	`{`
`950`	`950`	`struct rev_info revs;`
`951`	`951`	`struct commit_list *tried;`